tinygrad Missing int32 test coverage

Missing int32 test coverage

Open dc-dc-dc opened this issue 1 year ago • 3 comments

Int32 dtype test coverage is missing, add int32 tests to test/test_dtype.py.

In part should also resolve the issues with ops_cpu, as numpy will upcast an op between int32 and float32 to float64

Jul 07 '23 17:07 dc-dc-dc

Currently working on test coverage. Once that is complete, I will add the upcast from int32 and float32 to float32.

Jul 07 '23 18:07 FrostyTheSouthernSnowman

Turned out I also needed to add match_types call to FusedOps.MULACC. I did that inside the einsum_mulacc function

Jul 07 '23 20:07 FrostyTheSouthernSnowman

that was actually a bad idea. Code is fixed now and ready to be merged. This issue can be closed as soon as that merge happens

Jul 10 '23 23:07 FrostyTheSouthernSnowman