tinygo icon indicating copy to clipboard operation
tinygo copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

Shorten some make targets

Open QuLogic opened this issue 2 years ago • 4 comments

QuLogic avatar Sep 07 '21 07:09 QuLogic

Annoyingly, it seems stretch is too old to have a reasonably new cmake.

QuLogic avatar Sep 07 '21 08:09 QuLogic

It looks like there is a problem with the new CMake version on Debian stretch.

There is also a failure on Windows:

mingw32-make: *** No rule to make target 'build/compiler-rt.armv6m-none-eabi.a', needed by 'library'.  Stop.

aykevl avatar Sep 08 '21 20:09 aykevl

Fixing that failure on Windows depends on how you feel about the inline comment.

QuLogic avatar Sep 09 '21 05:09 QuLogic

This generally looks good, thanks for the cleanups! However, I think we should remain on stretch for now. Eventually we'll have to switch, at which point we'll automatically have the newer CMake version. (Also, note that no build failure is triggered now because we're caching the LLVM build - but the PR as is doesn't seem correct). I would suggest undoing the change that requires the newer CMake version or waiting until we switch to buster or another distro.

aykevl avatar Sep 21 '21 21:09 aykevl