tinygo icon indicating copy to clipboard operation
tinygo copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

atsamd21: fix SPI when SDI is set to NoPin

Open aykevl opened this issue 4 years ago • 5 comments

Untested

This should fix an issue when SDI is set to machine.NoPin. This is already fixed for the samd51, in a basically identical way.

aykevl avatar Nov 16 '20 13:11 aykevl

TinyHCI tests pass, so seems good.

deadprogram avatar Nov 27 '20 17:11 deadprogram

The following solves the problem. So we can close this PR without merging it.

2540172cc5c684772480f895a682591c63dee7bb

sago35 avatar Feb 15 '21 23:02 sago35

Correction.

Since the code for samd5x has been changed by the following PR, it is better to change the code for samd2x in the same way. In other words, it is better to merge this PR.

https://github.com/tinygo-org/tinygo/pull/1485

sago35 avatar Feb 15 '21 23:02 sago35

@aykevl What do you think?

sago35 avatar Feb 15 '21 23:02 sago35

The differences are as follows image

sago35 avatar Mar 11 '21 12:03 sago35