tinygo builder: simplify detection of Clang header paths

builder: simplify detection of Clang header paths

Open aykevl opened this issue 4 years ago • 6 comments

This detection mechanism should work on both Debian and Fedora, and hopefully other Linux distributions too.

By simplifying this it should be possible to more easily add exceptions for specific systems.

Note, this should be merged after the coming release to avoid potential disruption.

Nov 04 '20 00:11 aykevl

Hello @QuLogic does this look like it will address some of the issues you have pointed out in Fedora?

Dec 15 '20 05:12 deadprogram

@QuLogic did you happen to see this PR? What do you think?

Dec 23 '20 07:12 deadprogram

I did not fully test this, but it seems okay, except that I don't think Glob is guaranteed to be in any order: golang/go#17153

Jan 27 '21 10:01 QuLogic

Oops, somehow overlooked this PR. Is it still relevant/needed?

Nov 06 '21 20:11 deadprogram

except that I don't think Glob is guaranteed to be in any order: golang/go#17153

Fair enough. I've added a sort.Strings call to be sure.

Is it still relevant/needed?

It's still a simplification and simplifying things is usually a good thing. So I'd say yes.

Nov 10 '21 18:11 aykevl

Just wondering if this still works as we expect?

Apr 11 '22 14:04 deadprogram