Uc8151 Improvements DrawBitmap and DrawBuffer

[conejoninja]

[deadprogram]

@conejoninja please rebase against latest dev. Thanks!

[conejoninja]

Probably the first time I rebase locally, hope I didn't screw up.

[deadprogram]

Probably the first time I rebase locally, hope I didn't screw up.

That was perfect. :+1:

[aykevl]

DrawBuffer is a new interface, why didn't you use the conventional DrawBitmap interface? (Or even DrawRGBBitmap8)

[conejoninja]

DrawBitmap already exists and it calls d.SetPixel for each pixel, but I already had the buffer with the data in the correct format, should should avoid a bunch of operations if just copy it instead. It's convenient (in my case)

[deadprogram]

DrawBitmap already exists and it calls d.SetPixel for each pixel

Perhaps you would like to improve the implementation of DrawBitmap() instead? :smile_cat:

[conejoninja]

DrawBitmap already exists and it calls d.SetPixel for each pixel

Perhaps you would like to improve the implementation of DrawBitmap() instead? 😸

Not sure if possible or worthy. Each byte of the buffer represent a row of 1x8 pixels. Using arbitrary coordinates x,y (ie not a multiple of 8), size and different rotations could be quite complex.

[deadprogram]

Just coming back around to this, since the badger2040 repo is using it.

What should we do?