bluetooth icon indicating copy to clipboard operation
bluetooth copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

sd: use constants from C instead of magic numbers

Open aykevl opened this issue 3 years ago • 1 comments

This change depends on https://github.com/tinygo-org/tinygo/pull/1896.

aykevl avatar May 20 '21 15:05 aykevl

@aykevl since https://github.com/tinygo-org/tinygo/pull/1896 has been merged and released, perhaps this PR can be completed now.

deadprogram avatar Jul 11 '21 08:07 deadprogram

Bump 🆙

ysoldak avatar May 26 '23 21:05 ysoldak

Rebased, and marked ready for review.

aykevl avatar May 31 '23 16:05 aykevl

Build failing here: https://github.com/tinygo-org/bluetooth/actions/runs/5135514068/jobs/9241035877?pr=65#step:7:8

deadprogram avatar May 31 '23 19:05 deadprogram

Huh odd, seems like it isn't quite working yet.

aykevl avatar Jun 01 '23 12:06 aykevl

Looking good now, thanks for the improvement @aykevl

deadprogram avatar Jun 03 '23 06:06 deadprogram