bluetooth icon indicating copy to clipboard operation
bluetooth copied to clipboard

Add Write command to the gattc implementaitons (windows hat already one)

Open Fabianexe opened this issue 1 year ago • 4 comments

This tries to solve issue #153 and add a Write function to all gattc implementations (windows hat already one).

I am on a Mac and the Darwin implementation works fine for me. The linux implementation is taken form @aykevl comment. For sd implementation I have looked in the api reference and it seems like the simple change form WRITE_CMD to WRITE_REQ does the trick.

However, I have no possibility to test the linux or sd implementation properly. Thus, it would be welcome if somebody else could verify that they work es attended.

Fabianexe avatar Dec 10 '23 10:12 Fabianexe

However, I have no possibility to test the linux or sd implementation properly. Thus, it would be welcome if somebody else could verify that they work es attended.

The quickest way to get this change merged is to only send tested code. If you can't test on Linux or with the SoftDevice, I suggest leaving those implementations out. (As a reviewer, it takes a lot of time to test every change so if you can confirm all the code you submit actually works it saves a lot of time - if you can confirm it works and the code looks reasonable, I'm fine with merging it).

aykevl avatar Dec 25 '23 15:12 aykevl

I have put the from me testet Mac part into a new PR #212

I am not sure what to do with this PR. After all it would be nice if write would be available on all systems. Thus, if somebody test it further parts could me merged.

Fabianexe avatar Dec 26 '23 12:12 Fabianexe

@Fabianexe looks like the code needs to be go fmt.

Also, does the newly merged https://github.com/tinygo-org/bluetooth/pull/216 change anything in your implementation?

deadprogram avatar Jan 03 '24 19:01 deadprogram

Yes this PR will need to be updated after #216.

aykevl avatar Jan 04 '24 15:01 aykevl