tinygiant98

Results 18 comments of tinygiant98

Sorry for the late reply. Looks like `--root` isn't working because it appears that that nsc is looking for the game on windows with a hardcoded c:\ directory. Yours is...

> Please add these test cases to make sure it didn't regress anything: Added in d9e31dc.

> Kind of confusing visually with constants already using underscores as separator Yup, can be visually cluttering if they're used excessively. I used them somewhat excessively in the testing example...

@mtijanic I tried using the apostrophe as an additional separator and it quite literally froze my computer when I attempted to compile my test script. Didn't bother to dig deep...

@jd28 Well, that's worded much more succinctly than my comment. However the rule is the same, I think, except allowing it to be used right after the 'x', 'b' or...

@niv Nope! No feature request or necessity involved in this one, more of a "just cuz I already had the code lying around". Or is it laying around? Perfectly happy...

> You should add the bits listed under Testing as actual test cases here: https://github.com/niv/neverwinter.nim/blob/master/tests/scriptcomp/corpus/constants.nss Wilco, I completely forgot there was a testing script. Maybe add that to the PR...

Note: Hold on to any merges for this ... for some reason, I'm getting errors on any hex number that ends in an alphabetic character. I'll go through that debug...