erppeek
erppeek copied to clipboard
Integration with IPython
Hi, sorry for this very late review, but you want to support IPython in erppeek, it's great.
but maybe you could change the dependencies and add ipython for the support.
Thank you
its great
👍 yes, very cool
but maybe you could change the dependencies and add ipython for the support
its an optional feature, so its shouldnt go in setup.py
nor is it a requirement, a real dependency
my 2 cents is that this is acceptable.
log.info("IPython not found, vanilla python REPL used") to hint support for
ipython` might be a gentle hint, but could be merged as is
ipython is optional, for this reason I do not think it is necessary to use it as a direct dependency