erppeek icon indicating copy to clipboard operation
erppeek copied to clipboard

Integration with IPython

Open arkhan opened this issue 8 years ago • 3 comments

arkhan avatar Nov 12 '15 16:11 arkhan

Hi, sorry for this very late review, but you want to support IPython in erppeek, it's great.

but maybe you could change the dependencies and add ipython for the support.

Thank you

matrixise avatar Jan 30 '18 09:01 matrixise

its great

👍 yes, very cool

but maybe you could change the dependencies and add ipython for the support

its an optional feature, so its shouldnt go in setup.py nor is it a requirement, a real dependency my 2 cents is that this is acceptable. log.info("IPython not found, vanilla python REPL used") to hint support for ipython` might be a gentle hint, but could be merged as is

jf--- avatar Jan 31 '18 21:01 jf---

ipython is optional, for this reason I do not think it is necessary to use it as a direct dependency

arkhan avatar Feb 09 '18 19:02 arkhan