tinypilot icon indicating copy to clipboard operation
tinypilot copied to clipboard

Use f-strings in places that pylint recommends

Open mtlynch opened this issue 3 years ago • 3 comments

New versions of pylint flag places where we can use Python f-strings instead of the legacy string formatting options.

We currently have pylint's check for this disabled because of our legacy code that uses the old formatting style, but we should replace those instances with modern f-strings and delete the suppression in .pylintrc.

mtlynch avatar Jun 17 '22 13:06 mtlynch

Hello, can I be assigned to this?

ezinneanne avatar Jun 17 '22 20:06 ezinneanne

Sure, that would be great!

This depends on #993, which is not yet merged into master, but you can fork from the pylint-2.14.2 branch and make these fixes.

mtlynch avatar Jun 17 '22 20:06 mtlynch

@ezinneanne - #993 is now merged, so you don't have to do anything special with branch forking. You can open a regular PR against the master branch.

mtlynch avatar Jun 20 '22 13:06 mtlynch

Hey, @mtlynch: I see that this issue is assigned, but it has been a while and it seems there is no progress on it (ex: ezinneanne has not even forked the repository). Can I get this assigned to me/work on this?

jmunoz94 avatar Oct 12 '22 01:10 jmunoz94

Sure, @jmunoz94 - assigned.

mtlynch avatar Oct 12 '22 09:10 mtlynch