tinypilot icon indicating copy to clipboard operation
tinypilot copied to clipboard

Adding Support for German Keyboard Layout when pasting - Dusty diamond/issue1830

Open DustyDiamond opened this issue 1 year ago • 3 comments

Hi, I added the translation table for German Special Characters. The Manual definition of ALT_GR is necessary since on german layouts the AltGr Key doesnt behave like the MODIFIER_RIGHT_ALT. In Tinypilot, pressing AltGr is interpreted like Ctrl Left + Alt Right which translates to hex 0x41, but it should be Ctrl Left + Alt Left (Hex 0x05) to work for German Special Characters.

Closes #1830

For an Quick overview for anyone later reading this, this would support the following special Characters:

!"§$%&(){}[]/+*#'-_.:,;äöüÄÖÜ<>|€?ß\~`´

Greetings from Germany :) Review on CodeApprove

DustyDiamond avatar Aug 14 '24 16:08 DustyDiamond

Automated comment from CodeApprove ➜

⏳ @jotaen4tinypilot please review this Pull Request

cghague avatar Aug 22 '24 01:08 cghague

Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request

cghague avatar Aug 22 '24 01:08 cghague

@jdeanwallace I have a German keyboard at hand for testing, so I’m happy to take care of the review. (Feel free to chime in anyways, but otherwise feel free to disregard or unassign your review request.)

jotaen4tinypilot avatar Aug 23 '24 10:08 jotaen4tinypilot