Add comments to wireless access point scripts

Open jdeanwallace opened this issue 1 year ago • 2 comments

Related https://github.com/tiny-pilot/tinypilot/issues/1711

This is a follow-up PR to a review comment asking for more code comments in our enable-wifi-ap and disable-wifi-ap scripts.

Apr 12 '24 14:04 jdeanwallace

@db39 - In https://github.com/tiny-pilot/tinypilot/pull/1778, we've converted your blog post code snippets to standalone scripts, with minor changes. However, I wasn't too sure if I understood what each command was doing.

This PR adds comments to these scripts. Could you double check that the comments make sense or suggest alternatives?

Apr 12 '24 15:04 jdeanwallace

Automated comment from CodeApprove ➜

⏳ @db39 please review this Pull Request

Apr 12 '24 15:04 jdeanwallace

@db39 - Just checking to see if this is still on your radar?

Jul 31 '24 09:07 jdeanwallace

@jdeanwallace - Thanks for the ping on this - it completely fell off my radar. I'll review it today.

Jul 31 '24 11:07 db39