tinypilot icon indicating copy to clipboard operation
tinypilot copied to clipboard

Avoid setting permissions recursively in TinyPilot Debian package

Open mtlynch opened this issue 3 years ago • 0 comments

Debian packages are not supposed to set permissions recursively in maintainer scripts:

https://lintian.debian.org/tags/recursive-privilege-change

We recursively call chown in postinst so we should figure out a way to avoid doing that:

https://github.com/tiny-pilot/tinypilot/blob/db00936f8caff794a831ec0a72b9cf0a78fbbc52/debian-pkg/DEBIAN/postinst#L3

Once we figure out the "right" way of handling this, we should remove the lintian rule suppression:

https://github.com/tiny-pilot/tinypilot/blob/0ef51cafd5d7091f272fc12218982dd9097d72dc/.lintianignore#L13-L15

mtlynch avatar Nov 15 '22 15:11 mtlynch