tinypilot icon indicating copy to clipboard operation
tinypilot copied to clipboard

Documentation for update mechanism

Open jotaen4tinypilot opened this issue 2 years ago • 2 comments

Resolves https://github.com/tiny-pilot/tinypilot/issues/1007.

Note (July 30th)

As mentioned in the ticket, I started to think about the documentation for the update mechanism:

  • This PR contains an outline of the aspects I think would be worth capturing. For now, I only set up the headlines/sections, wrote a few short sentences, and set up some bullet points to get the idea across. If we are happy with scope and structure, I’d phrase things properly and accurately. (I hope it’s not too rough and confusing, I just wanted to briefly check-in actually…)
  • I would only create a single instance of the documentation that covers things for both Community and Pro. (As opposed to covering the Pro-specific aspects only in the Pro repo.)
  • For gatekeeper, I think we could elaborate a bit more in the gatekeeper Readme, e.g. to give an overview how it integrates with Backblaze (e.g. the “special files” and our internal folder structure). Other than that, the project feels fairly self-explanatory for me, because of the code structure and comments.
  • I’d also briefly summarize the legacy update flow. It might be that in 3 years some user files a bug ticket, because they updated their device from 2020 for the first time, and it might not be immediately obvious to future devs that the update mechanism used to work differently back then. I’d also add some “historic” references, e.g. to the overhaul document or to the mega ticket.

Review on CodeApprove

jotaen4tinypilot avatar Jul 30 '22 16:07 jotaen4tinypilot

(Feedback is not urgent, as I’m off next week anyway.)

jotaen4tinypilot avatar Jul 30 '22 16:07 jotaen4tinypilot

Yep, this looks like a good direction to me.

mtlynch avatar Aug 10 '22 20:08 mtlynch

Automated comment from CodeApprove ➜

⏳ @mtlynch please review this Pull Request

jotaen4tinypilot avatar Aug 26 '22 17:08 jotaen4tinypilot

This is still on my radar. I was hoping to get it done while you were on vacation, but I'm still slammed with the hiring process for the support engineer role.

mtlynch avatar Sep 12 '22 15:09 mtlynch

This is still on my radar. I was hoping to get it done while you were on vacation, but I'm still slammed with the hiring process for the support engineer role.

No worries, it’s not urgent and I’m not blocked.

jotaen4tinypilot avatar Sep 13 '22 19:09 jotaen4tinypilot

Strange – the PR still shows up as “unapproved”. @mtlynch could you try to approve again, please? Maybe that somehow gets it unstuck 🤔

Screenshot 2022-09-21 at 11 12 05

vs

Screenshot 2022-09-21 at 11 13 42

jotaen4tinypilot avatar Sep 21 '22 09:09 jotaen4tinypilot

Hmm, I dunno just merge anyway.

mtlynch avatar Sep 21 '22 12:09 mtlynch