etna
etna copied to clipboard
Add `title` parameter to plots, make plots return figures
🚀 Feature Request
We want to add title for plots in etna.analysis
.
Proposal
- Find out whether
plt.show()
is necessary and if not, remove it from all the plots. This makes saving the plots impossible. - Make all plots return
matplotlib.figure.Figure
(it is enought, because with it you can access axes withfig.axes
). Don't forget aboutTSDataset.plot
. - Add parameter
title
to plots inetna.analysis.plotters
and set some default value.
- with a lot of plots that are using
prepare_axes
you can set plot withfig.suptitle
- remain only segment title for distinct subplot in
plot_correlation_matrix
,plot_feature_relevance
,plot_periodogram
- Add parameter
title
to plots inetna.analysis.eda_utils
and set some default value
- with a lot of plots that are using
prepare_axes
you can set plot withfig.suptitle
- pay attention to
stl_plot
: it differs from others
- Add parameter
title
forTSDataset.plot
and set some default value.
Test cases
- Make sure existing tests passes.
- Rerun notebooks with plots if necessary.
- Rerun readme example if necessary.
Additional context
No response