etna icon indicating copy to clipboard operation
etna copied to clipboard

[BUG] `_validate_intersecting_segments` in `plot_backtest_interactive` plotters and random folds

Open martins0n opened this issue 3 years ago • 0 comments

🐛 Bug Report

If we use FoldMask and there is intersection between folds plot_backtest_interactive raises error

Expected behavior

It should work like non-iteractive version

How To Reproduce

  • duplicate FoldMask for backtest
  • use wandb.logger with plot option

Environment

No response

Additional context

File "backtest.py", line 63, in <module>
    metrics, forecast, info = pipeline.backtest(ts=ts, **backtest_configs)
  File "/usr/local/lib/python3.8/site-packages/etna/pipeline/base.py", line 541, in backtest
    tslogger.log_backtest_metrics(ts, metrics_df, forecast_df, fold_info_df)
  File "/usr/local/lib/python3.8/site-packages/etna/loggers/base.py", line 147, in log_backtest_metrics
    logger.log_backtest_metrics(ts, metrics_df, forecast_df, fold_info_df)
  File "/usr/local/lib/python3.8/site-packages/etna/loggers/wandb_logger.py", line 136, in log_backtest_metrics
    fig = plot_backtest_interactive(forecast_df, ts, history_len=100)
  File "/usr/local/lib/python3.8/site-packages/etna/analysis/plotters.py", line 438, in plot_backtest_interactive
    _validate_intersecting_segments(fold_numbers)
  File "/usr/local/lib/python3.8/site-packages/etna/analysis/plotters.py", line 278, in _validate_intersecting_segments
    raise ValueError("Folds are intersecting")

Checklist

  • [X] Bug appears at the latest library version

martins0n avatar Jun 15 '22 06:06 martins0n