etna icon indicating copy to clipboard operation
etna copied to clipboard

Fixes for `plot_residuals`

Open alex-hse-repository opened this issue 2 years ago • 0 comments

🚀 Feature Request

Fix some issues in plot_residuals

Motivation

Make eda method better

Proposal

  1. Add parameter mode: Union[Literal["macro"], Literal["per-segment"]] = "per-segment"
    • Mode "per-segment" is the current behavior
    • In mode "macro" values from all the segments should be plotted in one picture
  2. Improve the behavior working with fold masks in case of feature = "timestamp":
    • Now it should plot folds without huge whitespaces between(leave 3-5 points between the folds)
    • Make sure that xticks assigned correctly

It was suggested earlier to also do:

  1. Let's take out the residuals computation from the method
    • Now method should expect residuals_ts: TSDataset instead of forecast_df and ts
    • Remove the residuals computation inside the method and parameters forecast_df , ts, transforms

But we decided not to do it.

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • [ ] I discussed this issue with ETNA Team

alex-hse-repository avatar Apr 29 '22 12:04 alex-hse-repository