etna icon indicating copy to clipboard operation
etna copied to clipboard

[BUG] Dropping NaNs on fit in all of the models

Open alex-hse-repository opened this issue 3 years ago • 1 comments

🐛 Bug Report

We drop NaNs in fit here and here, however some models like Catboost are able to work with NaNs.

Expected behavior

We need to decide which behaviour is expected here:

  1. Drop NaNs as we do now
  2. Drop NaNs inside the Adapter where it is necessary
  3. Do not drop NaNs

How To Reproduce

Environment

No response

Additional context

No response

Checklist

  • [X] Bug appears at the latest library version

alex-hse-repository avatar Feb 21 '22 14:02 alex-hse-repository

Waiting for tests

alex-hse-repository avatar Mar 25 '22 05:03 alex-hse-repository