panda-syntax-vscode icon indicating copy to clipboard operation
panda-syntax-vscode copied to clipboard

Extremely low contrast in diff viewer for comment changes.

Open jyboudreau opened this issue 5 years ago • 7 comments

Summary

Looking at diffs using the VSCode diff editor shows really low contrast text to background especially with backgrounds.

Language: JavaScript (Possibly other languages that have comments syntax highlighting)

Just diff any two files with changes in comments and you can see the problem. Here is a screenshot.

test_diff_contrast

I love Panda syntax, this is the only thing that is really annoying.

jyboudreau avatar Jul 18 '18 21:07 jyboudreau

I also love Panda syntax, but this issue is even worst when seeing code changes:

image

piedrahitapablo avatar Oct 12 '18 16:10 piedrahitapablo

+1

Nikodermus avatar Dec 18 '19 18:12 Nikodermus

+1

lukefan6 avatar Sep 03 '21 07:09 lukefan6

As of 2021 I am still facing this issue. Pandas is amazing, but this single issue is making me switch to a different theme. 😢

kashishkhullar avatar Sep 04 '21 12:09 kashishkhullar

Found a solution for it. Customize the color theme is the user settings.

    "workbench.colorCustomizations": {
        "[Panda Syntax]": {
            "diffEditor.insertedTextBackground": "#ff0000" // add some shade of green here
            "diffEditor.removedTextBackground": "#ff0000" // add some shade of red here
        }
    },

kashishkhullar avatar Sep 06 '21 07:09 kashishkhullar

Found you will need a alpha value in the colour code so you can still see the letters diff eg "diffEditor.removedTextBackground": "#e9464655", "diffEditor.insertedTextBackground": "#31dc3155"

ChrisWongCH avatar Sep 20 '21 05:09 ChrisWongCH

Really liked the theme, but the color for diff viewer is not very eye-friendly.

dharmjit avatar Oct 01 '21 17:10 dharmjit