panda-syntax-vscode icon indicating copy to clipboard operation
panda-syntax-vscode copied to clipboard

Add more italic

Open lednhatkhanh opened this issue 6 years ago • 5 comments

This theme uses Operator Mono for demonstration but doesn't support italic font, so please, add more italic.

For example: import, from, JSX propNames, async/await,...

lednhatkhanh avatar Jan 28 '18 03:01 lednhatkhanh

Tagging along on this. The theme should definitely support italics on certain classes to increase legibility.

nickkquan avatar Feb 02 '18 06:02 nickkquan

I think there's a balance of using italic vs normal font styling and I think it's user preference. Perhaps there could be an alternate version of the font that utilizes the italics a bit more.

Anyway, you can do this yourself using the User Settings. To do everything you've listed there, shove this in your settings file:

"editor.tokenColorCustomizations": {
    "[Panda Syntax]": {
        "textMateRules": [
            {
                "name": "Panda Italics",
                "scope": [
                    "source.js entity.other.attribute-name",
                    "source.js keyword.control",
                    "source.js storage.modifier"
                ],
                "settings": {
                    "fontStyle": "italic"
                }
            }
        ]
    }
}

lachieh avatar Mar 06 '18 19:03 lachieh

@lachieh If you can please add this feature to panda-vscode 👍

siamak avatar Mar 06 '18 21:03 siamak

@lachieh thank you so much! But real quick though where can I find more of those names (e.g source.js storage.modifie). I interested in making my own version of panda syntax.

mazwrld avatar Nov 24 '19 21:11 mazwrld

@doseofmazen From the documentation, there are guides that show how to make your own theme and there are also examples which have some instructions.

lachieh avatar Nov 25 '19 15:11 lachieh