template: formatPartition(): more generic implementation, never returns bare input

[rpardini]

template: formatPartition(): more generic implementation, never returns bare input

• template: formatPartition(): more generic implementation, never returns bare input Signed-off-by: Ricardo Pardini [email protected]
• tests for formatPartition() Signed-off-by: Ricardo Pardini [email protected]

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 52.83%. Comparing base (29c4b32) to head (434a286). :warning: Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   52.83%   52.83%   -0.01%     
==========================================
  Files         107      107              
  Lines        7203     7202       -1     
==========================================
- Hits         3806     3805       -1     
  Misses       3111     3111              
  Partials      286      286              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jacobweinstock]

Hey @rpardini, this looks good. Ready to get it merged?

[rpardini]

Rebased with Sign-off's. Ready.

[mergify[bot]]

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at ac936b08e2f1207a03db8ebf34a849d310f4e95f

This pull request spent 3 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

Mergify needs the author permission to update the base branch of the pull request. @rpardini needs to authorize modification on its head branch.

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[mergify[bot]]

Merge Queue Status

✅ The pull request has been merged at 434a286ce8d159294710f3c2215246fd1fd8bc3e

This pull request spent 9 minutes in the queue, including 2 minutes 55 seconds running CI. The checks were run in-place.

Required conditions to merge

• #changes-requested-reviews-by=0
  • [X] #399
• [X] base=main
• [X] check-success=DCO
• [X] check-success=build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)
• [X] check-success=build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)
• [X] check-success=validation
• label!=do-not-merge
  • [X] #399
• label=ready-to-merge
  • [X] #399
• [X] any of:
  • #approved-reviews-by>=1
    • [X] #399
  • author=jacobweinstock
    • [ ] #399
• [X] any of [🛡 GitHub branch protection]:
  • [X] check-success = DCO
  • [ ] check-neutral = DCO
  • [ ] check-skipped = DCO
• [X] any of [🛡 GitHub branch protection]:
  • [X] check-success = validation
  • [ ] check-neutral = validation
  • [ ] check-skipped = validation
• [X] any of [🛡 GitHub branch protection]:
  • [X] check-success = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)
  • [ ] check-neutral = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)
  • [ ] check-skipped = build-binaries (tink-agent, cross-compile-agent, tink-agent-binaries)
• [X] any of [🛡 GitHub branch protection]:
  • [X] check-success = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)
  • [ ] check-neutral = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)
  • [ ] check-skipped = build-binaries (tinkerbell, cross-compile, tinkerbell-binaries)
• [X] any of [🛡 GitHub repository ruleset rule]:
  • [X] check-success = validation
  • [ ] check-neutral = validation
  • [ ] check-skipped = validation