tink icon indicating copy to clipboard operation
tink copied to clipboard

Add controller component to identify non-unique Hardware ID values

Open chrisdoherty4 opened this issue 2 years ago • 0 comments

Summary

Hardware needs a unique identifier that can be used to pass to Tink Agent instances. If the value isn't unique within the whole cluster it leads to undefined behavior. This task is to build a system component that will provide information to operators that a Hardware resource is invalid.

Solutions

  1. We are experimentally checking uniqueness of MACs and IPs in the Hardware admission webhook. We could expand this to include the Hardware ID.
  2. Add conditions to Hardware resources that indicate a resource is valid. The MAC and IP uniqueness checks would be included with the ID check.
  3. In addition to (2) we can populate an Event on Hardware resources further indicating its invalid.

Additional data as specified in (2) could further be used in decisions around Workflow dispatch. For example, we could refuse to dispatch a Workflow if the associated Hardware resource is invalid.

chrisdoherty4 avatar Nov 18 '23 22:11 chrisdoherty4