tink icon indicating copy to clipboard operation
tink copied to clipboard

Add Vendordata to metadata

Open displague opened this issue 3 years ago • 4 comments

Description

Adds a vendordata key to the metadata structure. This will be used by tinkerbell/hegel#62

Why is this needed

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

The addition of a vendordata path will allow for differentiation between "userdata" and "vendordata" as described in https://cloudinit.readthedocs.io/en/latest/topics/vendordata.html

Checklist:

I have:

  • [ ] updated the documentation and/or roadmap (if required)
  • [ ] added unit or e2e tests
  • [ ] provided instructions on how to upgrade

displague avatar Jan 12 '22 18:01 displague

Codecov Report

Merging #579 (557dc0c) into main (1618650) will increase coverage by 0.09%. The diff coverage is n/a.

:exclamation: Current head 557dc0c differs from pull request most recent head 5ed656b. Consider uploading reports for the commit 5ed656b to get more accurate results

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   44.43%   44.52%   +0.09%     
==========================================
  Files          61       61              
  Lines        3497     3519      +22     
==========================================
+ Hits         1554     1567      +13     
- Misses       1862     1870       +8     
- Partials       81       82       +1     
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/hardware_types.go 100.00% <ø> (ø)
pkg/controllers/workflow/controller.go 73.68% <0.00%> (-2.51%) :arrow_down:
server/dbserver_worker_workflow.go 89.92% <0.00%> (-1.44%) :arrow_down:
server/kubernetes_api_workflow.go 29.00% <0.00%> (-0.23%) :arrow_down:
pkg/apis/core/v1alpha1/workflow_methods.go 76.27% <0.00%> (+1.27%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jan 25 '22 16:01 codecov[bot]

@chrisdoherty4, mind taking a look at this?

jacobweinstock avatar Jun 14 '22 15:06 jacobweinstock

This seems OK for the Kube back-end. Do we need anything in the database? Do we need a discussion around continued database support?

chrisdoherty4 avatar Jun 14 '22 15:06 chrisdoherty4

I think we're good to merge this!

chrisdoherty4 avatar Jul 30 '22 00:07 chrisdoherty4

rebased

displague avatar Aug 16 '22 15:08 displague