tink icon indicating copy to clipboard operation
tink copied to clipboard

Published 20 hours ago • verified publisher icon tinkerbell

Return empty WorkflowContextList from GetWorkflowContextList

Open swills opened this issue 3 years ago • 4 comments

Fixes #391

swills avatar Dec 30 '21 08:12 swills

@swills See the DCO notes https://github.com/tinkerbell/tink/pull/575/checks?check_run_id=4695236298 and please squash the second commit into the first.

I tried to reproduce the make generate problem locally but I ran into problems with make tools not being providing the tools needed for make generate. For CI, this may be corrected by https://github.com/tinkerbell/tink/pull/563/commits/73ca7c792f2715d02b111c35377a6f47388abb7d

displague avatar Jan 03 '22 20:01 displague

@swills See the DCO notes https://github.com/tinkerbell/tink/pull/575/checks?check_run_id=4695236298 and please squash the second commit into the first.

Done

I tried to reproduce the make generate problem locally but I ran into problems with make tools not being providing the tools needed for make generate. For CI, this may be corrected by 73ca7c7

Maybe. The real fix imho is https://github.com/actions/setup-go/pull/175 see also https://github.com/tinkerbell/tink/pull/553

swills avatar Jan 03 '22 21:01 swills

Hey @swills, sorry for having this sit so long. Would you mind checking out the merge/rebase conflicts?

jacobweinstock avatar Apr 19 '22 15:04 jacobweinstock

@swills we'd love to get this in. Are you able to rebase and address any issues?

chrisdoherty4 avatar May 03 '22 16:05 chrisdoherty4

Thanks for the effort. Unfortunately this change is redundant because of https://github.com/tinkerbell/tink/pull/654.

chrisdoherty4 avatar Dec 22 '22 15:12 chrisdoherty4