tink icon indicating copy to clipboard operation
tink copied to clipboard

Tink worker should never exit

Open mmlb opened this issue 3 years ago • 1 comments

Tink worker should pass on any errors back to tink server but remain up. Otherwise the machine needs to be rebooted in order to get tink worker back up and running and ready to process more workflows. This seems unnecessary just to deal with an error, imagine if init did the same ;).

Expected Behaviour

Tink worker reports back errors but continues to stay up and connected to tink server.

Current Behaviour

Tink worker exits and we need to reboot or log in and restart tink-worker to get into a workflow processing state again.

mmlb avatar Mar 17 '21 19:03 mmlb

This is a duplicate of this https://github.com/tinkerbell/tink/issues/458#issuecomment-797825897 but it is written in a better form! So I will close the old one in favor of this!

gianarb avatar Mar 18 '21 14:03 gianarb

Tink worker should be in a better position with https://github.com/tinkerbell/tink/pull/655, i believe there is still lots of room for improvement though and we have a roadmap item to refactor tink-worker entirely.

jacobweinstock avatar Dec 23 '22 02:12 jacobweinstock