tink icon indicating copy to clipboard operation
tink copied to clipboard

Add support for public registries

Open displague opened this issue 5 years ago • 5 comments

Currently, docker registry username, password, and host values must be provided throughout the Tinkerbell ecosystem.

While authenticated Docker registries are practical for production deployments, in development and home lab environments this additional configuration and requirement creates a burden and restricts use.

By making these registry arguments optional, we enable:

  • local registries without authentication (such as the kind-local registry)
  • running workflows using upstream images directly

This may require changes to boots, tink-worker, and perhaps others. This issue only reflects the tink-worker changes.

Originally posted by @detiber in https://github.com/tinkerbell/tink/pull/287#r491130186

displague avatar Sep 21 '20 21:09 displague

Also see https://github.com/tinkerbell/tink/pull/287/files#r491163737

displague avatar Sep 21 '20 21:09 displague

This is in some way related to #134 and #90 . Community is asking for both. Give us a secure environment and remote passwords.

Consistency is the only takeaway here

gianarb avatar Sep 22 '20 06:09 gianarb

@gianarb I think it might be tangentially related.

Ideally we'd support working with an existing registry host more easily, which is what this would be targeting. Ideally if we do deploy a registry it should be secure, but if a user already has a registry (or wants to use a public registry), then we should allow for it to be used and not necessarily require authentication for pulls.

detiber avatar Sep 22 '20 15:09 detiber

FYI, this ticket and others that are similar have been captured in this discussion https://github.com/tinkerbell/tink/discussions/586

jacobweinstock avatar Feb 08 '22 16:02 jacobweinstock

https://github.com/tinkerbell/tink/pull/607 touches on this a little bit

mmlb avatar Apr 18 '22 21:04 mmlb

close by https://github.com/tinkerbell/tink/pull/607

jacobweinstock avatar Dec 23 '22 02:12 jacobweinstock