smee
smee copied to clipboard
support ipxe scripts over data uris in ipxe script urls
Description
from https://github.com/tinkerbell/boots/pull/192#discussion_r687810189
Why is this needed
Fixes: #110
How Has This Been Tested?
Tests are failing, I haven't looked into how to fix this yet. I think the existing mocks may not be sufficient.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@displague still working this one?
@jeremytanner I would like to see this work continued for #110. I am stalled on it.
@jacobweinstock do you see what I'd like to have here (based on the test)? Is this the right place for this change and tests?
Hey @displague, apologies for the lack of response here. I will put this on my priority list for this week/next and update here when I have something concrete to provide. Again, sorry for the delay.
:( still haven't got around to this quite yet.
PR overall looks good - is it just stuck on there being a failing test?
Based on comment history it looks like this one is still awaiting @jacobweinstock to prioritize and review. Assigning failing test label based on description
@displague more rebasing for you
@displague, looks like this is still in draft and has some merge conflicts. will wait for updates before reviewing?
The code base has moved on quite a bit. Feel free to reopen.