smee icon indicating copy to clipboard operation
smee copied to clipboard

support ipxe scripts over data uris in ipxe script urls

Open displague opened this issue 4 years ago • 8 comments

Description

from https://github.com/tinkerbell/boots/pull/192#discussion_r687810189

Why is this needed

Fixes: #110

How Has This Been Tested?

Tests are failing, I haven't looked into how to fix this yet. I think the existing mocks may not be sufficient.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • [ ] updated the documentation and/or roadmap (if required)
  • [ ] added unit or e2e tests
  • [ ] provided instructions on how to upgrade

displague avatar Aug 14 '21 00:08 displague

@displague still working this one?

jeremytanner avatar Sep 21 '21 15:09 jeremytanner

@jeremytanner I would like to see this work continued for #110. I am stalled on it.

@jacobweinstock do you see what I'd like to have here (based on the test)? Is this the right place for this change and tests?

displague avatar Sep 21 '21 15:09 displague

Hey @displague, apologies for the lack of response here. I will put this on my priority list for this week/next and update here when I have something concrete to provide. Again, sorry for the delay.

jacobweinstock avatar Oct 05 '21 15:10 jacobweinstock

:( still haven't got around to this quite yet.

jacobweinstock avatar Oct 19 '21 15:10 jacobweinstock

PR overall looks good - is it just stuck on there being a failing test?

tstromberg avatar Nov 02 '21 16:11 tstromberg

Based on comment history it looks like this one is still awaiting @jacobweinstock to prioritize and review. Assigning failing test label based on description

crayzeigh avatar Feb 08 '22 16:02 crayzeigh

@displague more rebasing for you

cprivitere avatar Mar 08 '22 16:03 cprivitere

@displague, looks like this is still in draft and has some merge conflicts. will wait for updates before reviewing?

jacobweinstock avatar Mar 08 '22 16:03 jacobweinstock

The code base has moved on quite a bit. Feel free to reopen.

jacobweinstock avatar Apr 04 '23 15:04 jacobweinstock