tink icon indicating copy to clipboard operation
tink copied to clipboard

Make aws kms client use proxy

Open duanasq opened this issue 4 years ago • 2 comments

Addresses the proxy aspect of this issue.

I'm not familiar with c++ so very open to suggestions!

Gosh there are a lot of proxy environment variable variations. I'm just getting it working for the following variations now:

HTTPS_PROXY=https://username:[email protected]:1234 HTTPS_PROXY=https://someproxy.host:1234 HTTPS_PROXY=http://username:[email protected]:1234 HTTPS_PROXY=http://someproxy.host:1234

TODO

  • [ ] make sure it works also for HTTPS_PROXY=host:port

Thx

duanasq avatar Apr 19 '21 09:04 duanasq

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Apr 19 '21 09:04 google-cla[bot]

@googlebot I signed it!

duanasq avatar May 11 '21 01:05 duanasq

Sorry that this was never considered. We did not have the cycles to work on this, and even consider this. It might be necessary for someone to fork this. Note that this will be moved to https://github.com/tink-crypto/tink-cc-awskms

tholenst avatar Jan 31 '24 16:01 tholenst