tink icon indicating copy to clipboard operation
tink copied to clipboard

Add ability to specify custom keyset reader/writer for AndroidKeysetManager

Open varahash opened this issue 5 years ago • 3 comments

Fixes #264

varahash avatar Oct 19 '19 13:10 varahash

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Oct 19 '19 13:10 googlebot

@googlebot I signed it!

varahash avatar Oct 19 '19 13:10 varahash

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Oct 19 '19 13:10 googlebot

We decided that we don't want to add this to the AndroidKeysetManager. Instead of using custom readers/writers, it is preferable that users implements the reading/writing themselves.

juergw avatar Jan 26 '23 16:01 juergw