dependabot-azure-devops icon indicating copy to clipboard operation
dependabot-azure-devops copied to clipboard

provide a workaround for ruby/resolv/issues/23

Open BobSilent opened this issue 1 year ago • 6 comments

Hi @mburumaxwell,

this PR revives the changes that PR #369 brought with it and unfortunately were lost some time ago.

Can you please add this once again, until Ruby Resolv bug gets merged.

Thanks a lot.

BobSilent avatar Oct 04 '23 13:10 BobSilent

If I get this correctly, WORKAROUND_CMD will be an ENV variable? What are some of the values that would be set?

mburumaxwell avatar Oct 04 '23 14:10 mburumaxwell

Please see the details here #369

The issue I have is that within my network environment the docker host itself cannot resolve any network name, therefore some nameservers are configured, but unfortunately due to the bug (ruby/resolv/issues/23) I need to "patch" the /etc/resolv.conf before the image runs. Currently I create an own docker image which is exactly the same as your images, with just one additional line during startup: sed -i 1' s/^/#/' /etc/resolv.conf in order to comment out the first nameserver entry which I am having issues with.

Currently I add an extra env with this value sed -i 1' s/^/#/' /etc/resolv.conf

BobSilent avatar Oct 04 '23 16:10 BobSilent

Since you are building custom images, have you tried adding that to your Dockerfile with a custom bin/run.sh? For example:

ARG ECOSYSTEM
FROM ghcr.io/tinglesoftware/dependabot-updater-$ECOSYSTEM

WORKDIR ${DEPENDABOT_HOME}
COPY --chown=dependabot:dependabot run.sh bin/run.sh

mburumaxwell avatar Oct 05 '23 01:10 mburumaxwell

That's what I'm doing right now, but to be honest I would really prefer to use your image out-of-the-box, without any modifications from my site. As this has the downside that I frequently have to update and maintain my images, if they do not work with an updated extension.

That's why I really would like to ask you to add this minor and non breaking change again here - even if this is against your code cleanness (which I completely understand). 🙏

I'll continue to get the real fix PR merged @ruby/resolv - but unfortunately there I did not get any response up to now.

BobSilent avatar Oct 05 '23 08:10 BobSilent

That's why I really would like to ask you to add this minor and non breaking change again here - even if this is against your code cleanness (which I completely understand). 🙏

I'll continue to get the real fix PR merged @ruby/resolv - but unfortunately there I did not get any response up to now.

Thulasi225 avatar Apr 22 '24 12:04 Thulasi225

  • WORKAROUND for https://github.com/ruby/resolv/issues/23, see also https://github.com/tinglesoftware/dependabot-azure-devops/pull/369

Thulasi225 avatar May 17 '24 09:05 Thulasi225