Martín Dias

Results 460 comments of Martín Dias

For the immutability check, I opened a new issue (#118). For the others, there was a long discussion.

The only other implementor is: ``` DebuggerSettings class>> emergencyDebugger ^ self environment at: #EDEmergencyDebugger ifAbsent: [ DebuggerEmmergencyLogger new ] ```

The user in Bloc is: ``` BlBlocUIManager >> onPrimitiveError: aString | message | message := String streamContents: [:s | | context | s nextPutAll: '*** System error handling failed ***'....

`DebuggerEmmergencyLogger` is just subclass of `Object`, and I don't read specification of what's the common API with `EDEmergencyDebugger`. But by browsing I detected the only selector in common: `debugError:fromSession:`. Maybe...

In other words, I don't see an equivalent of `askForEmergencyEvaluatorOrExitWithText:` that receives only a string. I should ask to the debuggers' team.

It may be better to close this PR without merging. See comments in #151.

Looking for other references to `BlSpartaRenderer`, found too: - `Bloc class>>#preferableSpartaCanvas` - `Bloc class>>#preferableSpartaCanvas:` among others. @syrel Any suggestion how to rewrite it?

The other reference is: ~~~smalltalk Bloc class >> hasSparta ^ self environment includesKey: #BlSpartaRenderer ~~~ and there are sends here: ~~~smalltalk BlElement >> visualBounds "Visual bounds represent a high precision...

- For traits: okay. For Fuel we used FLT for traits and I thought it was following a general rule. - For `Br*`, we can rename to `Bl*` Do we...