Martín Dias

Results 460 comments of Martín Dias

That commit wasn't really a fix. It was a mere workaround

Related to https://github.com/pharo-graphics/Bloc/commit/1834af8c9f8876c9cb88784aa71863bcb52eaa81

I'm looking for the equivalent in P13 of `(RPackageOrganizer default packageNamed: #'Bloc-Demo')` to fix 2 tests in `BlDemoBasicNodeTest`. @jecisc do you know?

Another occurrence: ``` BlDemoPresenter>> packagesToCollect ^ RPackageOrganizer default packages select: [ :each | each name includesSubstring: 'Bloc' ] ```

Thanks @jecisc ! Yes, I like the deprecation and new way to to it. To make it work from p11 to p13, I'm replacing by `self class packageOrganizer`. Because `packageOrganizer`...

The cause of the remaining 2 failing tests are what is reported in #433

#664 fixed last 2 failing tests that break CI

For the record, I did a first try and failed to fix it. I share the code below. I created this test in `BlEventTest`: ```smalltalk testAnnouncementSet | element events |...

I think I narrowed a bit the cases to these: ``` svg := ToAntDesignIconProvider outlined_moon. (BlSvgConverter convertFromString: svg). svg := ToAntDesignIconProvider filled_muted. (BlSvgConverter convertFromString: svg). svg := ToAntDesignIconProvider filled_pinterest. (BlSvgConverter...

@plantec Please look at this results in Bloc:dev + Toplo:dev. Same filled_muted svg string is rendered and adapted to BlElement's size, but (as you reported) it is not shown by...