🔧 Refactor: Editorial Workflow PR generation modal
Changes
Users could navigate away during the PR creation process in the editorial workflow. This PR ensures that the user stays within the modal during the process.
This PR includes several improvements to the editorial workflow:
- 🗑️ Removed IndexingPage.tsx and cleaned up routing
- 🔧 Refactored branch creation workflow to eliminate IndexingPage dependency and contain its logic in the modal
Description
This PR focuses on streamlining the editorial workflow by removing the IndexingPage dependency. The changes maintain all functionality while making the codebase more maintainable.
🦋 Changeset detected
Latest commit: 84cee449e9617a7c73d4bc8545bc0abfd44116b9
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
| Name | Type |
|---|---|
| tinacms | Patch |
| next-tinacms-azure | Patch |
| next-tinacms-cloudinary | Patch |
| next-tinacms-dos | Patch |
| next-tinacms-s3 | Patch |
| tinacms-authjs | Patch |
| tinacms-clerk | Patch |
| @tinacms/app | Patch |
| @tinacms/cli | Patch |
| @tinacms/vercel-previews | Patch |
| playwright-testing | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Playwright E2E Test Results
7 passed
2 skipped
Details
9 tests across 6 suites
35.8 seconds
84cee44
Skipped tests
chromium › retain-input-value-from-localstorage.spec.ts › Local storage retain edit test chromium › rich-text-editor/newline-parsing.spec.ts › should be able to parse newline from markdown
⚠️ No Changeset found
Latest commit: 4219812
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets Click here to learn what changesets are, and how to add one.
[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/tinacms/tinacms/new/editorial-workflow-pr-generation?filename=.changeset/kind-cats-occur.md&value=---%0A%22tinacms%22%3A%20patch%0A---%0A%0A%F0%9F%94%A7%20Editorial%20Workflow%20Refactoring%0A)
Please also add a changeset (can click the "Click here if you're a maintainer who wants to add a changeset to this PR" to create a changeset) @kulesy
Helps the UX for this PBI #2236 as the user cannot internally navigate away unintentionally from the Editorial Workflow PR generation
Used staging for testing - Branch and PR were created successfully but the modal displayed said there was an error and the branch was not created. Also seem to be getting CORS errors
Hey Jack, tested on my local today, failed for the first time at the same place when creating pr
As testers have been experiencing some issues and the PR for the PBI https://github.com/tinacms/tinacloud/issues/2798 will be out soon (making this UX flow redundant), I will close this PR.