tinacms icon indicating copy to clipboard operation
tinacms copied to clipboard

🔧 Refactor: Editorial Workflow PR generation modal

Open kulesy opened this issue 10 months ago • 4 comments

Changes

Users could navigate away during the PR creation process in the editorial workflow. This PR ensures that the user stays within the modal during the process.

This PR includes several improvements to the editorial workflow:

  • 🗑️ Removed IndexingPage.tsx and cleaned up routing
  • 🔧 Refactored branch creation workflow to eliminate IndexingPage dependency and contain its logic in the modal

Description

This PR focuses on streamlining the editorial workflow by removing the IndexingPage dependency. The changes maintain all functionality while making the codebase more maintainable.

kulesy avatar Jun 10 '25 07:06 kulesy

🦋 Changeset detected

Latest commit: 84cee449e9617a7c73d4bc8545bc0abfd44116b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
tinacms Patch
next-tinacms-azure Patch
next-tinacms-cloudinary Patch
next-tinacms-dos Patch
next-tinacms-s3 Patch
tinacms-authjs Patch
tinacms-clerk Patch
@tinacms/app Patch
@tinacms/cli Patch
@tinacms/vercel-previews Patch
playwright-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 10 '25 07:06 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 10 '25 07:06 CLAassistant

Playwright E2E Test Results

passed  7 passed
skipped  2 skipped

Details

stats  9 tests across 6 suites
duration  35.8 seconds
commit  84cee44

Skipped tests

chromium › retain-input-value-from-localstorage.spec.ts › Local storage retain edit test chromium › rich-text-editor/newline-parsing.spec.ts › should be able to parse newline from markdown

github-actions[bot] avatar Jun 10 '25 07:06 github-actions[bot]

⚠️ No Changeset found

Latest commit: 4219812

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/tinacms/tinacms/new/editorial-workflow-pr-generation?filename=.changeset/kind-cats-occur.md&value=---%0A%22tinacms%22%3A%20patch%0A---%0A%0A%F0%9F%94%A7%20Editorial%20Workflow%20Refactoring%0A)

Please also add a changeset (can click the "Click here if you're a maintainer who wants to add a changeset to this PR" to create a changeset) @kulesy

JackDevAU avatar Jun 11 '25 00:06 JackDevAU

Helps the UX for this PBI #2236 as the user cannot internally navigate away unintentionally from the Editorial Workflow PR generation

kulesy avatar Jun 17 '25 00:06 kulesy

Used staging for testing - Branch and PR were created successfully but the modal displayed said there was an error and the branch was not created. Also seem to be getting CORS errors

Hey Jack, tested on my local today, failed for the first time at the same place when creating pr

Ben0189 avatar Jun 27 '25 06:06 Ben0189

As testers have been experiencing some issues and the PR for the PBI https://github.com/tinacms/tinacloud/issues/2798 will be out soon (making this UX flow redundant), I will close this PR.

kulesy avatar Jun 29 '25 22:06 kulesy