tinacms icon indicating copy to clipboard operation
tinacms copied to clipboard

🐛 Bug - Inline Nested rich text not rendering correctly

Open JackDevAU opened this issue 1 year ago • 4 comments

Hi Team,

When using inline rich text that has nested rich text fields, on save the form field goes blank. Breaks the indentation in the nested markdown, resulting in loss of formatting. For instance, an ordered list may be arranged into a single line.

 {
      name: 'assessment',
      label: 'Assessment',
      type: 'rich-text',
      templates: [
        {
          name: 'dropBox',
          label: 'DropBox',
          inline: true,
          fields: [
            {
              name: 'title',
              label: 'Short Description',
              type: 'string',
              required: true,
            },
            {
              name: 'body',
              label: 'Expanded Information',
              type: 'rich-text',
              required: true,
            },
          ],
        },
      ],
    },

Reproduction

Here is the video showing form not saving repro video

check discord for more related nested rich text bug

Steps to reproduce

No response

System Info

all

Validations

JackDevAU avatar Jun 20 '24 02:06 JackDevAU

Update:

PR has been created: https://github.com/tinacms/tinacms/pull/4590 Some more work is needed to fix other test cases which are now failing with the new method.

JackDevAU avatar Jun 28 '24 00:06 JackDevAU

Update: ✅ All test case and build passed ❌ The pr does not fix the bug (More spike needed)

Task:

  • [x] Repo issue before fix
  • [x] Clone branch and test the fix locally
  • [x] Do some clean up on PR
  • [x] Review PR https://github.com/tinacms/tinacms/pull/4590

Ben0189 avatar Jul 08 '24 01:07 Ben0189

As per our discussion during weekly meeting with @jeffsee55, the pr is still not solving the problem completely (not production ready due to some edge case might break). It can't handle the Eduard's use case (see Edaurd's video - in discord channel demonstrating the bug) . More investigation is needed to achieve this, so the PR is currently marked as a draft.

Ben0189 avatar Jul 11 '24 02:07 Ben0189

CC: @JackDevAU @wicksipedia @Jord-Gui

As per our conversation, a spike PBI needed for this bug fix see spike on embed component solution

Ben0189 avatar Jul 15 '24 02:07 Ben0189

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 11 '25 03:01 stale[bot]