tina-starter-grande icon indicating copy to clipboard operation
tina-starter-grande copied to clipboard

keyboard scrolling only works on foccusable elements

Open hanspoo opened this issue 5 years ago • 2 comments

Hi,

Thanks for the great job, it looks very nice and the online editing is cool.

I've tested on firefox and chrome in the desktop.

The problem is that when i focus on the page content with a click, and then use the keyboard arrow keys or page up and page down to scroll, it doesn't do anything, I've been debugging the page for a while not finding a solution.

To reproduce click the home page press arrow keys to scroll down

expected: page scroll down result: nothing happens

It doesn't work in the official starter demo https://tina-starter-grande.netlify.com/

It works when clicking on focusable elements like buttons or tabs scroll works, but in any other part of the page it doesn't.

Thanks

hanspoo avatar Jan 18 '20 11:01 hanspoo

I've found the problem, it was a css rule in siteLayout.js component, this fix, this the change required:

hans@urantia:~/gatsby/aprende-react$ git diff
diff --git a/src/components/siteLayout.js b/src/components/siteLayout.js
index c3da21d..c84e113 100644
--- a/src/components/siteLayout.js
+++ b/src/components/siteLayout.js
@@ -109,7 +109,7 @@ export const Site = styled.div`
   ${props =>
     props.theme.hero.parallax &&
     css`
-      height: 100vh;
+      /* height: 100vh; */
       overflow-y: auto;
       overflow-x: hidden;
       perspective: 1px;

hanspoo avatar Jan 19 '20 12:01 hanspoo

Thanks for reporting this, @hanspoo. I'll try that fix out locally and get it merged in soon if it checks out.

spbyrne avatar Jan 20 '20 19:01 spbyrne