vscode-tinacious-design-syntax icon indicating copy to clipboard operation
vscode-tinacious-design-syntax copied to clipboard

Some Warning and Error colours, Currently highlighted issue in Problems, are Invisible in Light theme

Open stellarpower opened this issue 4 years ago • 5 comments

Hey,

Love the theme. But one thing that's been really frustrating is that one colour in particular seems to come out invisible, as light on a light background. I'm assuming, it could be a quirk in my system, but I finally switched over to a different light theme to see and it was fixed.

For me, it's the colour that the currently selected line in the Problems pane is. I've also just installed the output colouriser extension, and the same issue for the colour that warnings and errors are shown up as. Which is great as that's the only reason I installed it! :P

Including some screenshots of how it looks for me. Possibly related is #30.

Problems pane:

image

Colourised output pane:

image

image

stellarpower avatar Nov 16 '21 15:11 stellarpower

Thanks so much for creating this issue! That definitely looks like a problem. I appreciate you taking the time to report this bug.

Can you provide an example project and steps to reproduce? It looks like one of the steps is to install the output coloriser plugin you noted, I'm wondering if there's a sample project I can use to see this.

tinacious avatar Nov 19 '21 00:11 tinacious

You're welcome! I think it simply ought to come up if there are any issues in the build process for any project, unless it's something specific that's happening to me - does that happen for you?

stellarpower avatar Nov 21 '21 23:11 stellarpower

image image Another place I forgot - errors in JSON. Can be tricky as I can't see what I'm doing! To reproduce, try to add an item to an array of strings, but leave off the initial quote.

stellarpower avatar Nov 29 '21 02:11 stellarpower

image

tebievx avatar Apr 29 '23 20:04 tebievx

Thanks @tebievx ! Opening a patch above for this.

stellarpower avatar Apr 30 '23 14:04 stellarpower