Tim Wojtulewicz

Results 289 comments of Tim Wojtulewicz

Right. It never went beyond that one CI test.

Given that we haven't really seen this again, I'm going to just close this.

There's a question here about how to handle built-in plugins against external plugins. If an external plugin is loaded when one with a plugin with the same name is built-in,...

One thing that might help here is setting the size of the dictionary when we create it in `TableVal::DoClone()`. That would avoid a large number of resizes. Alternatively, we could...

I added some instrumentation to `DoClone()`. It's definitely something to do with the insertion into the new table. Even in the 1100000-element case above, eventually it hits a point where...

This is from Instruments.app, with sizes 1400000 and 1500000. ![Screen Shot 2022-08-30 at 11 47 15 AM](https://user-images.githubusercontent.com/2653616/187518422-986fbbe1-1d5b-4b99-8f59-8297ac07272f.png) ![Screen Shot 2022-08-30 at 11 47 29 AM](https://user-images.githubusercontent.com/2653616/187518443-63cc841f-a6ee-4cc6-afda-f95a4bcc83be.png) Clearly remapping is causing a...

Some more notes, just so I can keep this straight in my brain. The big question mark right now is why the initial insertion and the insertion during `copy()` is...

One thing that came to me last night (while I was doing the dishes) was a question of why we are doing this re-insertion thing anyways for `Dictionary`. We've already...

The problem is that you're re-inserting the keys after they've already been reordered by the first insertion, and ending up hitting the same pathological case as `TableVal::DoClone()`. It's why I...

I added some code in 9ff8f3b079436a4759d6ceeae617374738f70552 that special cases a `Dictionary::Clone` method for `TableVal` that lets it just iterate over the table array and rebuild a new table without having...