Tim Wojtulewicz

Results 293 comments of Tim Wojtulewicz

Should control characters continue to be escaped? I'm thinking in the case of a few of our tests such as https://github.com/zeek/zeek/blob/master/testing/btest/Baseline/bifs.fmt/out (has newlines and tabs being escaped), https://github.com/zeek/zeek/blob/master/testing/btest/Baseline/bifs.hexdump/out (has a...

The "number of others" above are mostly places where we print out something like a signature. Printing UTF-8 characters in those cases seems like a step backwards. We're already printing...

I agree with this not being a 3.0.1 issue. It's not breaking anything for print to be over-escaping the UTF-8 characters, and there's clearly some other factors in question.

I think the primary problem is that the change modifies `BroString::Render` which is called from lots of other places than just `print` (via `ODesc::Add`). How about adding another flag to...

Finally coming back around to this one. After spending a little bit of time looking at it, I think adding a flag to `BroString::render_style` and then making sure that's set...

> Or maybe I made it more complicated/conservative than it needs to be I don't think you did, but I agree I don't think there's an easy path. There's a...

There's been a lot of work around printing/escaping UTF8 recently. I wonder if this could be more easily-resolved now.

@JustinAzoff is this something you want to stick into a PR? I'm not sure it'll make it at this point for 4.2, but we could definitely get it in for...

Is there anything to do here, or are the conscious decisions @vpax mentioned something we're going to leave as is?

The other good thing about this is that it'll fix all of these: ![Screen Shot 2022-08-11 at 3 20 18 PM](https://user-images.githubusercontent.com/2653616/184252281-63499495-033b-4dd3-a951-489d2c4949d3.png)