mkdocs-git-authors-plugin icon indicating copy to clipboard operation
mkdocs-git-authors-plugin copied to clipboard

Authorship_threshold_percent ignored

Open christophhillisch opened this issue 2 years ago • 3 comments

I am running into the problem that configurations beyond the first one (show_contribution: true) are ignored. I set authorship_threshold_percent: 10, but I found contributions of 0.88 %.

Package Versions:

  • mkdocs 1.4.2
  • mkdocs-git-authors-plugin 0.7.0
  • mkdocs-git-revision-date-localized-plugin 1.1.0
  • mkdocs-material 9.0.13
  • mkdocs-material-extensions 1.1.1
  • python 3.10

Relevant parts in mkdocs.yml:

plugins:
  - search:
      lang: en
  - git-revision-date-localized:
      enable_creation_date: true
      fallback_to_build_date: false
      timezone: Europe/Paris
  - git-authors:
      show_contribution: true
      sort_authors_by: contribution
      authorship_threshold_percent: 10

christophhillisch avatar Feb 22 '23 13:02 christophhillisch

I'm seeing the same behaviour where contributors below the threshold are still shown.

Also, when using sort_authors_by: contribution instead of name, it does not sort them by name anymore, but the order (%) of contribution is not correct.

Using:

  • mkdocs==1.4.0
  • mkdocs-git-authors-plugin==0.6.4
  • mkdocs-git-revision-date-localized-plugin==1.0.1
  • mkdocs-material==8.5.11
  • mkdocs-material-extensions==1.1.1

xsa avatar Apr 21 '23 10:04 xsa

I also have the same issue.

aazraq avatar Apr 22 '23 16:04 aazraq

Thanks for reporting, I will need to look into this when I can make time again.

timvink avatar May 22 '23 18:05 timvink