Results 139 comments of Tim Vink

`flake8` is great, but makes a lot of stylistic checks also. I've had it raise errors for things I don't want to 'fix'. Using it requires some work on defining...

Yes. Just trying to help.

Nice work! Make sure to add your plugin to the plugins wiki (https://github.com/mkdocs/mkdocs/wiki/MkDocs-Plugins) for more exposure. Closing this issue, no point to add plotly support to this plugin

That's strange, as the actual error is re-raised: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/blob/9cfce40942c83dd15834fb879caa4171a426ecdd/mkdocs_git_revision_date_localized_plugin/util.py#L139 Git errors come from the `GitPython` dependency, and are raised as-is. I don't have their error handling top of mind --...

@ldeluigi small reminder. Can you provide some more details?

Ahhh, I see! Thanks for clarifying, and yes, logging the error when there's a fallback makes sense. Probably a warning level log is more fitting than a info level log.

It's a cool trick, thanks for sharing! I don't feel that plugin should also do (automatic) overrides. I also don't want to mess with the sitemap, as `mkdocs` is responsible...

Sorry for the very late reply, this project has not been a priority.. Very cool PR, 5.5x improvement is considerable! One problem I see however is using the `files` collection...

Another promising avenue might be to tweak git a bit, there are a couple of settings for large repos that might `git blame` operations much faster: https://www.git-tower.com/blog/git-performance/ Have you tried...

@squidfunk I know you did this in several of your plugins. Any wisdom to share?