Shuttle2 icon indicating copy to clipboard operation
Shuttle2 copied to clipboard

ReplayGain adjustments applied after playback begins

Open keysmashes opened this issue 2 years ago • 5 comments

🌎 Environment

  • Environment:
  • Device: Pixel 4a
  • OS: Android 13 (TQ1A.230205.002)
  • App Version & Build: Version 1.0.7-beta1 (10070055)
  • Possible Cause:

💬 Description

ReplayGain volume adjustments are only applied after the track begins playing, which leads to a noticeable change in volume a fraction of a second into the track.

🦶 Reproduction Steps

Steps to reproduce the behavior:

  1. Tag your music with ReplayGain tags
  2. Play it
  3. Observe shifts in volume just after tracks begin (most noticeable with a quiet track followed by a loud track; the loud track is too loud for a moment)

🤔 Expected Results

When a track starts playing, ReplayGain volume adjustments should be applied immediately (or: a track should not start playing before its volume is adjusted per its ReplayGain tags)

😲 Actual Results

Tracks play at the previous track's volume for ~half a second before the correct volume adjustment is applied.

keysmashes avatar Mar 13 '23 10:03 keysmashes

@sersorrel I have a potential fix for this. But I'm wondering if you have a couple of example tracks or album that make this problem quite obvious?

timusus avatar Apr 21 '23 23:04 timusus

now I'm wishing I wrote down what albums I was noticing this with... I'll have limited opportunities to listen to music for the next few days, but after that I'll try to figure out what shows it best and get back to you

keysmashes avatar Apr 22 '23 22:04 keysmashes

aha, here's an example: the Outer Wilds soundtrack, going from Main Title (track 7) to The Search (track 8). there's a "click" noise and a slight drop in volume a moment after The Search starts. (be warned that Outer Wilds is a game that loses its impact if you have prior knowledge, so if you have not played it and might do so in the future I would avoid listening to or looking at the rest of the soundtrack; a similar thing happens with track 11 into track 12, but the titles of those tracks are arguably spoilers, imo.)

here's the ReplayGain information for my copy of track 7:

Replaygain Reference Loudness   : 89.0 dB
Replay Gain Track Gain          : -1.55 dB
Replay Gain Track Peak          : 0.78675842
Replay Gain Album Gain          : -7.26 dB
Replay Gain Album Peak          : 0.98855317

and for track 8:

Replaygain Reference Loudness   : 89.0 dB
Replay Gain Track Gain          : -5.72 dB
Replay Gain Track Peak          : 0.98855317
Replay Gain Album Gain          : -7.26 dB
Replay Gain Album Peak          : 0.98855317

my S2 install is configured to use Track Gain, with a -4dB preamp.

I'm sure there are better examples, I'll keep looking for one.

keysmashes avatar Apr 28 '23 14:04 keysmashes

another example: this is clearly audible on the puella magi madoka magica music collection (e.g. between tracks 1 and 2, 10 and 11, 11 and 12)

for what it's worth, I built the app at d90aa5b6fdecafd79f7edefb11f3ead81034147f (after that MR was merged) and the problem doesn't appear to be fixed, unfortunately

keysmashes avatar May 20 '23 00:05 keysmashes

một ví dụ khác: điều này có thể nghe rõ ràng trên bộ sưu tập nhạc puella magi madoka magica (ví dụ: giữa các bản nhạc 1 và 2, 10 và 11, 11 và 12)

với giá trị của nó, tôi đã xây dựng ứng dụng tại d90aa5b (sau khi MR đó được hợp nhất) và thật không may, vấn đề dường như chưa được khắc phục

djtuananh20 avatar Sep 26 '23 22:09 djtuananh20