Content-generator-sketch-plugin icon indicating copy to clipboard operation
Content-generator-sketch-plugin copied to clipboard

Persona isn't working with sketch 52

Open kommunicator opened this issue 6 years ago • 11 comments

Hi guys, Perosnas aren't working with new Sketch version.

Thanks for fixing it.

kommunicator avatar Oct 06 '18 17:10 kommunicator

Hello Guys,

I was trying to use Persona > Photos but is not working. I'm using Sketch 52.1 in macOS Mojave version 10.14

Thanks,

lisct avatar Oct 09 '18 22:10 lisct

Still no working in version 52.2

Please, try to fix it :((

Thanks a lot.

chimitron avatar Oct 30 '18 13:10 chimitron

Hi guys. Sketch 52 already comes with native dummy data functionality. Why would you need the plugin?

timuric avatar Nov 01 '18 13:11 timuric

It’s not the same. The plugin is specific, you select female or male for example.

lisct avatar Nov 01 '18 14:11 lisct

You could do the same by simply adding the your own pictures. You find the pictures used in the plugin here https://github.com/timuric/Content-generator-sketch-plugin/tree/master/CG.sketchplugin/Contents/Sketch/data/images/persona

timuric avatar Nov 01 '18 16:11 timuric

Oh! Thanks good to know!

lisct avatar Nov 02 '18 02:11 lisct

Still not working :(

shajeeamaan avatar Nov 08 '18 07:11 shajeeamaan

In my version 52.6 the code is not passing this line, because it's returning MSRectangleShape rather than the expected MSShapeGroup. I tweaked my local copy, but I'm largely ignorant of the way all this works, otherwise I'd submit a PR.

https://github.com/timuric/Content-generator-sketch-plugin/blob/766cebd18c261105e513090f8e7cf5abc76640aa/CG.sketchplugin/Contents/Sketch/js/loadImage.js#L57

nomad3k avatar Mar 03 '19 15:03 nomad3k

@nomad3k you can extend your snippet by adding an OR into the conditional:

|| [layer class] == MSOvalShape

olgageletina avatar Mar 08 '19 20:03 olgageletina

Looking forward to news of an update. 👍

dmora1979 avatar Apr 04 '19 07:04 dmora1979

This plugin no longer works as of sketch 53.2 They've added this feature to replace the need for timuric's plugin

Make a rectangle click "data" in the upper left click "sketch data" click "faces"

Knackerman avatar Apr 04 '19 18:04 Knackerman