BGHUDAppKit icon indicating copy to clipboard operation
BGHUDAppKit copied to clipboard

Should button outlines be drawn in the disabledStrokeColor in the disabled state? (patch included)

Open garethsb-ghost opened this issue 13 years ago • 0 comments

Should button outlines be drawn in the disabledStrokeColor in the disabled state? In particular, the disabled state of an unchecked HUD checkbox is hard to distinguish from an enabled one.

I've patched BGHUDButtonCell.m locally as follows:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDButtonCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDButtonCell.m >diff.txt
403c403
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
510c510
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
591c591
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
891c891
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
916c916
<                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
961c961
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
983c983
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];

Best regards, Gareth

garethsb-ghost avatar Apr 05 '11 12:04 garethsb-ghost