BGHUDAppKit
BGHUDAppKit copied to clipboard
Vertical slider doesn't draw correctly in disabled state (patch included)
BGHUDAppKit looks great. Thank you, Tim!
BGHUDSliderCell doesn't draw a vertical slider correctly in the disabled state. I think this is just an oversight and easily fixed by applying the code from the horizontal variant:
diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDSliderCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDSliderCell.m 308,312c308,322 < [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set]; < [path fill]; < < [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set]; < [path stroke]; --- > if([self isEnabled]) { > > [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set]; > [path fill]; > > [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set]; > [path stroke]; > } else { > > [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledSliderTrackColor] set]; > [path fill]; > > [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set]; > [path stroke]; > }
Thanks, Gareth Sylvester-Bradley
hmmm...I don't remember ever getting a notice of this one, I'll definitely get this and your other fixes in the repo, thanks for the help and sorry for the late reply.