Tim te Beek

`JUnitAssertThrowsToAssertExceptionType` does not convert cases where `executable` is a variable

2

## What version of OpenRewrite are you using? - https://github.com/openrewrite/rewrite-testing-frameworks/releases/tag/v2.6.0 ## What is the smallest, simplest way to reproduce the problem? ```java import org.junit.jupiter.api.function.Executable; import static org.junit.jupiter.api.Assertions.assertThrows; public class SimpleExpectedExceptionTest...

Issue discovered on `core/src/testFixtures/java/org/assertj/core/api/IdListAssert.java` with `Simplify AssertJ chained assertions`

1

### Problem > Describe the issue you are experiencing. ### Expected behavior > Describe what you expected to see. ### Example diff **From:** `core/src/testFixtures/java/org/assertj/core/api/IdListAssert.java` ```diff @Override public IdListAssert hasSize(int expected)...

`TestsShouldNotBePublic` should not reduce visibility if test classes are extended

4

[TestsShouldNotBePublic](https://github.com/openrewrite/rewrite-testing-frameworks/blob/v1.33.0/src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldNotBePublic.java) should not reduce visibility of classes used in subsequent test classes, even if those are in Groovy. As seen in https://github.com/openrewrite/rewrite/pull/2800. > Compilation fails as JavaTypeSignatureBuilderTest and JavaTypeMappingTest should...

`RemoveTestPrefix` should not (only) rename methods called from other methods

4

Quickly noted down here, can be tackled individually. - [x] Should not rename test when there's a static method import of the same name (can lead to conflicts) - [...

Handle breaking changes in Mockito 5

2

There's a number of [breaking changes coming up in Mockito v5](https://github.com/mockito/mockito/issues/2802), which we might want to support soon after their release. For now we're [pinned to v4](https://github.com/openrewrite/rewrite-testing-frameworks/blob/v1.32.0/src/main/resources/META-INF/rewrite/mockito.yml#L29), so nothing will...

Testcontainers best practices recipes

1

Based on this nice article from @sivaprasadreddy https://www.atomicjar.com/2023/11/testcontainers-best-practices/ ## What problem are you trying to solve? Automate some of the best practices for testcontainers, such that users can adopt these...

Adopt AssertJ duration assertions

5

## What problem are you trying to solve? More expressive assertions around durations, using the methods defined in: https://www.javadoc.io/static/org.assertj/assertj-core/3.24.2/org/assertj/core/api/DurationAssert.html ## What precondition(s) should be checked before applying this recipe? Durations...

## What problem are you trying to solve? As indicated here https://github.com/openrewrite/rewrite-testing-frameworks/issues/348#issuecomment-1665732048 and tested here: https://github.com/openrewrite/rewrite-testing-frameworks/pull/385/commits/3fda5860d33b04eac856b308840daa50dc3ae775 we don't yet support simplifying AssertJ when a reason is present after #385. Would...

Simplify AssertJ assertions related to arrays

2

## What problem are you trying to solve? We want to replace the array assertions listed in https://rules.sonarsource.com/java/RSPEC-5838   | before | after | | --- | --- | assertThat(getArray().length).isZero() |...

Collapse consecutive AssertJ `assertThat(..)` statements that each use the same object to a single statement

2

## What problem are you trying to solve? ## What precondition(s) should be checked before applying this recipe? Only consecutive calls; not when interleaved with others. Only when the asserted...