brew-pkg icon indicating copy to clipboard operation
brew-pkg copied to clipboard

incomplete package with git

Open kaloprominat opened this issue 11 years ago • 4 comments

Hi ! Building pkg for git formula creates package without some necessary git resources. Packages contains dirs:

. └── usr └── local ├── Library ├── bin ├── etc ├── lib ├── libexec └── share

when git wants some other files:

Failed to perform checkout on agent: '/usr/local/bin/git init --bare' command failed. stdout: Initialized empty Git repository in /Users/teamcity/buildAgent/system/git/git-3DEC8E2F.git/ stderr: warning: templates not found /usr/local/Cellar/git/2.0.4/share/git-core/templates

Obviously, package should contain /usr/local/Cellar/git too.

kaloprominat avatar Aug 21 '14 15:08 kaloprominat

Yes some packages are staticly linking agains paths in Cellar. I've run into this issue also with Ghostscript and ImageMagick.

If I do: mkdir -p /usr/local/Cellar/ghostscript/${GHOSTSCRIPT_VERSION}/share/ ln -s /usr/local/share/ghostscript /usr/local/Cellar/ghostscript/${GHOSTSCRIPT_VERSION}/share/ghostscript

Then it works. And I have to create other directories and symlinks for ImageMagick.

It would be nice to not need the Cellar at all, but having a way to automatically create the Cellar directories and links would also help.

kcrawford avatar Oct 31 '14 17:10 kcrawford

Btw, i forked this brew-pkg and modified it to include Cellar resources. Also added some related option as command line argument. You can check out my version here https://github.com/kaloprominat/brew-pkg

kaloprominat avatar Nov 05 '14 10:11 kaloprominat

The @kaloprominat fork works perfectly (was having same issue with nspr/nss packaging). Any plan to pull these changes back into original?

sheurich avatar Feb 02 '15 22:02 sheurich

+1 for the @kaloprominat fork. It made packaging up Grace (xmgrace) work a treat!

grahampugh avatar Feb 04 '15 17:02 grahampugh