Tim Snyder
Tim Snyder
Should we use pathlib/universal_path in the manager or avoid it? Started from : > I hate to say this... but we should probably port to using `pathlib` everywhere. (just a...
Python has several builtin exception types https://docs.python.org/3.8/library/exceptions.html `Exception` is a base class that all user defined Exception Types are encouraged to derive from. The FireSim manager routinely raises the base...
Every few months, we have the manager crash during the run of a workload. It usually looks like: ``` -------------------------------------------------------------------------------- Summary -------------------------------------------------------------------------------- 22/34 instances are still running. 22/34 simulations are...
It would be good if you added a comment explaining this logic, and made it more clear at the top of the file the conditions under which sudo is required...
https://github.com/firesim/firesim/blob/716b28d65438f94b1910c1ad658f5934fce75033/scripts/machine-launch-script.sh#L98-L99 Different options on the two lines above will be confusing. I messed up when I changed only one, not the other, should refactor into a variable.
### Background Work - [X] Yes, I searched the [mailing list](https://groups.google.com/forum/#!forum/firesim) - [X] Yes, I searched [prior issues](https://github.com/firesim/firesim/issues) - [X] Yes, I searched the [documentation](https://docs.fires.im/en/stable/) ### FireSim Version and Hash...
### Background Work - [X] Yes, I searched the [mailing list](https://groups.google.com/forum/#!forum/firesim) - [X] Yes, I searched [prior issues](https://github.com/firesim/firesim/issues) - [X] Yes, I searched the [documentation](https://docs.fires.im/en/stable/) ### FireSim Version and Hash...
https://github.com/firesim/firesim/blob/9b817ed5822b7129b05d7cc5ab368edb1657ebbe/deploy/runtools/run_farm.py#L387-L394 While looking at something else I came across this. Would it make sense to either: 1. use `local('git -C {deploy_dir}/../platforms/f1/aws-fpga describe --tags --always --dirty')` to introspect the version of...
> @sagark, is it a "feature" that the manager continues waiting if a switch is found to be not running? I would expect that you would want the manager to...
### Background Work - [X] Yes, I searched the [mailing list](https://groups.google.com/forum/#!forum/firesim) - [X] Yes, I searched the [documentation](https://docs.fires.im/en/stable/) ### Feature Description Instead of having `build-setup.sh fast` clone binaries out of...