heroku-buildpack-github-netrc
heroku-buildpack-github-netrc copied to clipboard
Buildpack fails on Heroku-22 due to no system Ruby
Hi!
The Heroku-22 stack was just released: https://devcenter.heroku.com/changelog-items/2429
However in Heroku-22, there is no longer a system install of Ruby: https://devcenter.heroku.com/articles/heroku-22-stack#system-ruby-is-no-longer-installed
This buildpack is written entirely in Ruby, and so currently does not work on Heroku-22.
Heroku has it's own fork of this buildpack (https://github.com/heroku/heroku-buildpack-github-netrc), which has solved the issue with Heroku-22 by converting the buildpack to use bash scripts instead of Ruby: https://github.com/heroku/heroku-buildpack-github-netrc/pull/3
I would recommend either:
- Pulling in those changes into this repo.
- Or, if you no longer wish to maintain this repo (now that there's a Heroku version), adding deprecation warning messages to the output of this buildpack encouraging users to migrate to the Heroku version.
Many thanks :-)
I would recommend either:
1. Pulling in those changes into this repo. 2. Or, if you no longer wish to maintain this repo (now that there's a Heroku version), adding deprecation warning messages to the output of this buildpack encouraging users to migrate to the Heroku version.
@timshadel Hi! Any thoughts on the above? :-)
@edmorley wow! I had no idea this repo was still being used by others. I'm happy to bring in the changes blindly from the Heroku "fork-not-fork", but as I'm not actively using this buildpack I'd need someone to try it out. Would you be willing to help me out with testing?
@timshadel Hi! Thank you for the reply.
People are already using https://github.com/heroku/heroku-buildpack-github-netrc and manual testing for the conversion from Ruby to bash was also performed in: https://github.com/heroku/heroku-buildpack-github-netrc/pull/3#issuecomment-1166486620
However, if you don't use this buildpack any more, perhaps a deprecation warning (or hard failure) might be best? (That suggests people switch to https://github.com/heroku/heroku-buildpack-github-netrc)