Tim Sehn comments

Results 334 comments of


                                            Tim Sehn

Experimental pgo file

Should we close this now that we build with PGO?

Messaging on a merge where a table was altered and deleted on each side of the merge not helpful

At least change the error message to list the tables that generated the error. Something like: ``` Error. Merge aborted. Table a was deleted and modified on either side of...

Messaging on a merge where a table was altered and deleted on each side of the merge not helpful

This is resolved by #7390

Update triggers do not fire on `dolt table import -u`

This is particularly high priority because it impacts DoltHub editing using CSV or Spreadsheet.

Add transparent Git+Dolt integration (aka Ressurect git-dolt)

We will look into scheduling this work for you. Just need someone to free up on our side.

Add transparent Git+Dolt integration (aka Ressurect git-dolt)

We discussed this with another customer and suggested using Git Hooks (https://git-scm.com/docs/githooks) along with a file in your Git repo where you store metadata about the Dolt repository you want...

Table size calculation using DATA_LENGTH in information schema is naive and massively overstates the size of tables

We have an existing issue for this: https://github.com/dolthub/dolt/issues/5202 And there is a bigger project to collect table stats so we can populate these columns: https://github.com/dolthub/dolt/issues/6161 The best way to see...

Table size calculation using DATA_LENGTH in information schema is naive and massively overstates the size of tables

So here is the code for DATA_LENGTH: https://github.com/dolthub/dolt/blob/cf5516a4ca8712beac8c04043711f1c5bc5f37ae/go/libraries/doltcore/sqle/tables.go#L396 And here is comment in the code for INDEX_LENGTH saying it is not supported: https://github.com/dolthub/go-mysql-server/blob/7898f495601614b0b1b42c1038c1ab545a0c2bae/sql/information_schema/information_schema.go#L1752 So, I think what is going on....

Table size calculation using DATA_LENGTH in information schema is naive and massively overstates the size of tables

Another user just reported this. We're discussing whether to simply multiply our current result by a fixed "compression factor" to give a more reasonable result.

`The current directory is not a valid dolt repository` error message after two users, one authenticated and one not, tried to access the same cloned repository

Thanks. @stephkyou will keep digging here.