repsnapper icon indicating copy to clipboard operation
repsnapper copied to clipboard

Unknown temp reading messages

Open hurzl opened this issue 14 years ago • 2 comments

Ultimaker Marlin emits "raw" temperature values, like ok T:30.00, raw:55 B:24.00

libreprap stops on the "raw" with error message, not continuing to read the bed temperature.

patch to ignore unknown keywords:


------------------------- libraries/libreprap/fived.c -------------------------
index 86adbaf..edcf937 100644
@@ -45,9 +45,10 @@ fived_handle_reply (rr_dev dev, const char *reply, size_t nbytes)
       case 'E':
    float_reply (dev, &i, RR_E_POS);
    break;
       default:
-   return rr_dev_emit_error (dev, RR_E_UNKNOWN_REPLY, reply, nbytes);
+   // return rr_dev_emit_error (dev, RR_E_UNKNOWN_REPLY, reply, nbytes);
+   break;
       }
     }
     return 0;
 

hurzl avatar Nov 25 '11 10:11 hurzl

I'd prefer to do a better job of detecting such things, and parsing them I think; we could add some 'RAW' variants of RR_NOZZLE_TEMP_RAW etc. and parse that thing correctly and emit them. Not sure we want them showing up in the UI. For a rolls-royce version - we should detect the Ultimaker Marlin by interrogating the machine on first connect, to detect this and only accept that stuff from an Ultimaker :-)

mmeeks avatar Nov 25 '11 11:11 mmeeks

I was trying to get a VW version without annoying messages ;-)

hurzl avatar Nov 25 '11 12:11 hurzl